Check if GetMenu returns a valid handle and change return type to int for GetMenuItemCount#306
Merged
chcg merged 3 commits intobruderstein:masterfrom Aug 23, 2023
Ekopalypse:master
Merged
Check if GetMenu returns a valid handle and change return type to int for GetMenuItemCount#306chcg merged 3 commits intobruderstein:masterfrom Ekopalypse:master
chcg merged 3 commits intobruderstein:masterfrom
Ekopalypse:master
Conversation
chcg
reviewed
Aug 22, 2023
chcg
reviewed
Aug 22, 2023
chcg
reviewed
Aug 22, 2023
Contributor
Author
|
I don't know what I was thinking, but you're right, of course. I can make the changes today after work. |
The change was made to match the type of the for loop variable to the value returned by GetMenuItemCount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves the issue that if the menu has been disabled by a user, getMenu returns a NULL pointer and then GetMenuItemCount, returns -1, which is cast to an unsigned int, which then means that it takes a very long time to iterate over non-existent menu items.
Fixes #305